[webkit-reviews] review granted: [Bug 179696] [Cocoa] Clean up names of conversion methods after renaming InspectorValue to JSON::Value : [Attachment 327797] Rebased Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Brian Burg
<bburg at apple.com>'s request for review:
Bug 179696: [Cocoa] Clean up names of conversion methods after renaming
InspectorValue to JSON::Value
https://bugs.webkit.org/show_bug.cgi?id=179696

Attachment 327797: Rebased Patch

https://bugs.webkit.org/attachment.cgi?id=327797&action=review




--- Comment #5 from Timothy Hatcher <timothy at hatcher.name> ---
Comment on attachment 327797
  --> https://bugs.webkit.org/attachment.cgi?id=327797
Rebased Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327797&action=review

Looks fine other than one comment.

>
Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_types_im
plementation.py:115
> -	   lines.append('-
(instancetype)initWithJSONObject:(RWIProtocolJSONObject *)jsonObject')
> +	   lines.append('-
(instancetype)initWithProtocolObject:(RWIProtocolJSONObject *)object')
>	   lines.append('{')
> -	   lines.append('    if (!(self = [super
initWithInspectorObject:[jsonObject toInspectorObject].get()]))')
> +	   lines.append('    if (!(self = [super initWithJSONObject:[object
toJSONObject].get()]))')

This seems odd. Why change [self initWithJSONObject:] to
initWithProtocolObject: when super is changing to initWithJSONObject:?

Maybe this method should be initWithProtocolJSONObject:?