[webkit-reviews] review granted: [Bug 180108] CodeBlockSet::deleteUnmarkedAndUnreferenced can be a little more efficient : [Attachment 327784] the patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 180108: CodeBlockSet::deleteUnmarkedAndUnreferenced can be a little more
efficient
https://bugs.webkit.org/show_bug.cgi?id=180108

Attachment 327784: the patch

https://bugs.webkit.org/attachment.cgi?id=327784&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 327784
  --> https://bugs.webkit.org/attachment.cgi?id=327784
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327784&action=review

r=me

> Source/JavaScriptCore/heap/CodeBlockSet.cpp:31
> +#include "SuperSampler.h"

You're not using this AFAICT

> Source/JavaScriptCore/heap/CodeBlockSet.cpp:87
> +    // FIXME: make CodeBlock::~CodeBlock a lot faster. It seems insane for
that to take 1us or more.

Indeed. That's crazy