[webkit-reviews] review granted: [Bug 180082] WebDriver: add an option to dump test results to a json file : [Attachment 327752] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 180082: WebDriver: add an option to dump test results to a json file
https://bugs.webkit.org/show_bug.cgi?id=180082

Attachment 327752: Patch

https://bugs.webkit.org/attachment.cgi?id=327752&action=review




--- Comment #2 from Brian Burg <bburg at apple.com> ---
Comment on attachment 327752
  --> https://bugs.webkit.org/attachment.cgi?id=327752
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327752&action=review

r=me

> Tools/Scripts/run-webdriver-tests:51
> +			    help='Write results to JSON file at the given
path')

Please set the metavariable.

> Tools/Scripts/run-webdriver-tests:72
> +    runner.dump_results_to_json_file(options.json_output)

Please validate that the provided path exists, or create it if needed.