[webkit-reviews] review granted: [Bug 179958] Fast binding generation by batching several files at once : [Attachment 327708] fix

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 179958: Fast binding generation by batching several files at once
https://bugs.webkit.org/show_bug.cgi?id=179958

Attachment 327708: fix

https://bugs.webkit.org/attachment.cgi?id=327708&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 327708
  --> https://bugs.webkit.org/attachment.cgi?id=327708
fix

View in context: https://bugs.webkit.org/attachment.cgi?id=327708&action=review

> Source/WebCore/bindings/scripts/generate-bindings-all.pl:167
> +    my $batchCount = 30;
> +    # my $batchCount = int(($totalCount - $currentCount) / $numOfJobs) || 1;

Let's not comment out a line.  Also, the second line isn't quite right either. 
As it is it strangely gives smaller batches as work progresses.  Let's do
something more like $totalCount / $numOfJobs.