[webkit-reviews] review denied: [Bug 180009] Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp : [Attachment 327732] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 180009: Modernize some aspects of text codecs, eliminate WebKit use of
strcasecmp
https://bugs.webkit.org/show_bug.cgi?id=180009

Attachment 327732: Patch

https://bugs.webkit.org/attachment.cgi?id=327732&action=review




--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 327732
  --> https://bugs.webkit.org/attachment.cgi?id=327732
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327732&action=review

Looks like some tests need fixing.

> Source/WebCore/platform/text/TextCodec.h:47
> +    virtual String decode(const char*, size_t length, bool flush, bool
stopOnError, bool& sawError) = 0;

This could return a std::optional<String> instead of passing in a bool&