[webkit-reviews] review denied: [Bug 180054] Dangerous downcast via static_cast for find delegate. : [Attachment 327678] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 180054: Dangerous downcast via static_cast for find delegate.
https://bugs.webkit.org/show_bug.cgi?id=180054

Attachment 327678: Patch

https://bugs.webkit.org/attachment.cgi?id=327678&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 327678
  --> https://bugs.webkit.org/attachment.cgi?id=327678
Patch

This is messy and kind of a layering violation.  I think it would be better to
set m_findClient to nullptr in WebPageProxy::close and check it for null
everywhere we use it.
There should also be an API test that exercises the bad behavior before the
change.