[webkit-reviews] review granted: [Bug 180057] Spread can escape when CreateRest does not : [Attachment 327692] patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 180057: Spread can escape when CreateRest does not
https://bugs.webkit.org/show_bug.cgi?id=180057

Attachment 327692: patch

https://bugs.webkit.org/attachment.cgi?id=327692&action=review




--- Comment #3 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 327692
  --> https://bugs.webkit.org/attachment.cgi?id=327692
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327692&action=review

r=me

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:5292
> +	       static_assert(sizeof(JSValue) == 8 && 1 << 3 == 8, "Assumed in
the code below.");

1 << 3 == 8 ? Seems pretty stable :p