[webkit-reviews] review granted: [Bug 180050] Implement OffscreenCanvas.getContext("webgl") : [Attachment 327666] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Dean Jackson <dino at apple.com>'s request
for review:
Bug 180050: Implement OffscreenCanvas.getContext("webgl")
https://bugs.webkit.org/show_bug.cgi?id=180050

Attachment 327666: Patch

https://bugs.webkit.org/attachment.cgi?id=327666&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 327666
  --> https://bugs.webkit.org/attachment.cgi?id=327666
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327666&action=review

> Source/WebCore/html/OffscreenCanvas.cpp:81
> +    if (m_context)
> +	   return { RefPtr<WebGLRenderingContext> {
&downcast<WebGLRenderingContext>(*m_context) } };

I think this should only return m_context if contextType ==
RenderingContextType::Webgl. Otherwise, it should be nullptr.