[webkit-reviews] review granted: [Bug 180041] Give Document a strongly typed identifier instead of a uint64_t : [Attachment 327648] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 180041: Give Document a strongly typed identifier instead of a uint64_t
https://bugs.webkit.org/show_bug.cgi?id=180041

Attachment 327648: Patch

https://bugs.webkit.org/attachment.cgi?id=327648&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 327648
  --> https://bugs.webkit.org/attachment.cgi?id=327648
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327648&action=review

> Source/WebCore/workers/service/ServiceWorkerClientIdentifier.h:40
> +    String toString() const { return
String::number(serverConnectionIdentifier.toUInt64()) + "-" + 
String::number(contextIdentifier.toUInt64()); }

Use StringBuilder?

Also, is this toString() being used to generate client ids, thus potentially
exposing to the web page server connection id and context id?
If so, I am wondering whether we should not use some random UUID, at least when
exposing the clientId to the web page, or have the storage process generate
those random IDs.