[webkit-reviews] review granted: [Bug 180005] [GTK][WPE] Add "enable-encryptedmedia" property to WebKitWebSettings : [Attachment 327627] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Yacine Bandou
<bandou.yacine at gmail.com>'s request for review:
Bug 180005: [GTK][WPE] Add "enable-encryptedmedia" property to
WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=180005

Attachment 327627: Patch

https://bugs.webkit.org/attachment.cgi?id=327627&action=review




--- Comment #9 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 327627
  --> https://bugs.webkit.org/attachment.cgi?id=327627
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327627&action=review

> Source/WebKit/ChangeLog:9
> +	   This proprety is available only if the EncryptedMedia feature is
enabled at build time by the ENABLE_ENCRYPTED_MEDIA flag.

property

> Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:1297
> +	* Enable or disable support for EncryptedMediaAPI on pages.

"encrypted media API"

> Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:1299
> +	* This proprety is available only if the EncryptedMedia feature is
enabled at build time

property

> Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:1300
> +	* by the ENABLE_ENCRYPTED_MEDIA flag.

"with the"

> Source/WebKit/UIProcess/API/gtk/WebKitSettings.h:438
> +								   gboolean    
   enabled);

Looks like the alignment is a bit off here, the g in "gboolean" should be
aligned with the W on the line above, not the (.

> Source/WebKit/UIProcess/API/wpe/WebKitSettings.h:422
> +								   gboolean    
   enabled);

Same here.