[webkit-reviews] review granted: [Bug 180016] [JSC] Remove JSStringBuilder : [Attachment 327584] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Nov 26 15:37:13 PST 2017
Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 180016: [JSC] Remove JSStringBuilder
https://bugs.webkit.org/show_bug.cgi?id=180016
Attachment 327584: Patch
https://bugs.webkit.org/attachment.cgi?id=327584&action=review
--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 327584
--> https://bugs.webkit.org/attachment.cgi?id=327584
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=327584&action=review
> Source/JavaScriptCore/runtime/JSStringInlines.h:50
> + String result = tryMakeString(string, strings...);
Would it be better to use forwarding semantics here?
More information about the webkit-reviews
mailing list