[webkit-reviews] review granted: [Bug 179976] [CoordGraphics] UpdateAtlas constructor should receive an IntSize, not a dimension value : [Attachment 327497] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 179976: [CoordGraphics] UpdateAtlas constructor should receive an IntSize,
not a dimension value
https://bugs.webkit.org/show_bug.cgi?id=179976

Attachment 327497: Patch

https://bugs.webkit.org/attachment.cgi?id=327497&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 327497
  --> https://bugs.webkit.org/attachment.cgi?id=327497
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327497&action=review

>
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp
:398
> +    static const int s_atlasSize = 1024;
> +    m_updateAtlases.append(std::make_unique<UpdateAtlas>(*this,
IntSize(s_atlasSize, s_atlasSize), flags));

If s_atlasSize is only used here for this, why not static IntSize s_atlasSize =
{ 1024, 1024 }; ?