[webkit-reviews] review granted: [Bug 179971] [CMake] Values of CMAKE_BUILD_TYPE from toolchain file are ignored : [Attachment 327524] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 179971: [CMake] Values of CMAKE_BUILD_TYPE from toolchain file are ignored
https://bugs.webkit.org/show_bug.cgi?id=179971

Attachment 327524: Patch

https://bugs.webkit.org/attachment.cgi?id=327524&action=review




--- Comment #6 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 327524
  --> https://bugs.webkit.org/attachment.cgi?id=327524
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327524&action=review

wow, this is certainly tricky.

> CMakeLists.txt:10
>  
> +project(WebKit)
> +
>  if (NOT CMAKE_BUILD_TYPE)
>      message(WARNING "No CMAKE_BUILD_TYPE value specified, defaulting to
RelWithDebInfo.")
>      set(CMAKE_BUILD_TYPE "RelWithDebInfo" CACHE STRING "Choose the type of
build." FORCE)

I think this deserves a comment line saying that calling project first is
needed to automatically define CMAKE_BUILD_TYPE from the toolchain file