[webkit-reviews] review granted: [Bug 179966] Minor ArrayBufferView cleanup : [Attachment 327484] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 179966: Minor ArrayBufferView cleanup
https://bugs.webkit.org/show_bug.cgi?id=179966

Attachment 327484: Patch

https://bugs.webkit.org/attachment.cgi?id=327484&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 327484
  --> https://bugs.webkit.org/attachment.cgi?id=327484
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327484&action=review

> Source/JavaScriptCore/runtime/ArrayBufferView.h:194
> +    // Do not replace with RELEASE_ASSERT; we want to avoid the virtual
byteLength() function call in release.

This shows that using the style checker to suggest replacing every last
ASSERT_WITH_SECURITY_IMPLICATION with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION
might not be the right thing to do.