[webkit-reviews] review granted: [Bug 179965] WebSWServerConnection should register/unregister itself with the StorageProcess : [Attachment 327483] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 179965: WebSWServerConnection should register/unregister itself with the
StorageProcess
https://bugs.webkit.org/show_bug.cgi?id=179965

Attachment 327483: Patch

https://bugs.webkit.org/attachment.cgi?id=327483&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 327483
  --> https://bugs.webkit.org/attachment.cgi?id=327483
Patch

Looks good. I noticed that we delete the copy constructor but not the
assignment operator from WebSWServerConnection; not sure if that’s good. I
don’t absolutely love WTF_MAKE_NONCOPYABLE, but one of its benefits is that it
deletes both. By the way, I just noticed that the "private:" in Noncopyable.h
is no longer needed, now that we use "delete". I should remove that since it
would make the macro easier to use.