[webkit-reviews] review granted: [Bug 179972] [CoordGraphics] Simplify CoordinatedGraphicsLayer's content buffer updates : [Attachment 327494] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 179972: [CoordGraphics] Simplify CoordinatedGraphicsLayer's content buffer
updates
https://bugs.webkit.org/show_bug.cgi?id=179972

Attachment 327494: Patch

https://bugs.webkit.org/attachment.cgi?id=327494&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 327494
  --> https://bugs.webkit.org/attachment.cgi?id=327494
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327494&action=review

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBuffer.h:-56
> -    class Client {
> -    public:
> -	   virtual ~Client() = default;
> -	   virtual void paintToSurfaceContext(GraphicsContext&) = 0;
> -    };

\o/

>
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cp
p:-859
> -void CoordinatedGraphicsLayer::didUpdateTileBuffers()
> -{
> -    if (!isShowingRepaintCounter())
> -	   return;
> -
> -    m_layerState.repaintCount = incrementRepaintCount();
> -    m_layerState.repaintCountChanged = true;
> -}

Why did you move this?

>
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cp
p:976
> +	       if (!coordinatedBuffer)
> +		   continue;

Dow we consider the tile to be still dirty in this case?

>
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:3
3
> +#include <WebCore/CoordinatedBuffer.h>

Can we forward declare this?