[webkit-reviews] review granted: [Bug 179970] [CoordGraphics] Remove relay CoordinatedBuffer::Client implementations : [Attachment 327490] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 179970: [CoordGraphics] Remove relay CoordinatedBuffer::Client
implementations
https://bugs.webkit.org/show_bug.cgi?id=179970

Attachment 327490: Patch

https://bugs.webkit.org/attachment.cgi?id=327490&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 327490
  --> https://bugs.webkit.org/attachment.cgi?id=327490
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327490&action=review

Yes!

>
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp
:114
> +    {
> +	   GraphicsContext& context = m_buffer->context();
> +	   context.save();
> +	   context.clip(rect);
> +	   context.drawImage(*m_image, rect, rect);
> +	   context.restore();
> +    }

Why do we need another scope?

> Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:92
> +    }

Ditto.