[webkit-reviews] review granted: [Bug 179463] Isolated Heaps caused an increase in reported leaks on the bots : [Attachment 327244] the patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 179463: Isolated Heaps caused an increase in reported leaks on the bots
https://bugs.webkit.org/show_bug.cgi?id=179463

Attachment 327244: the patch

https://bugs.webkit.org/attachment.cgi?id=327244&action=review




--- Comment #12 from Darin Adler <darin at apple.com> ---
Comment on attachment 327244
  --> https://bugs.webkit.org/attachment.cgi?id=327244
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327244&action=review

Read this carefully. Did not spot any errors. Yet all my comments are about
trivia.

> Source/bmalloc/bmalloc/DebugHeap.h:50
> -
> +    

Added whitespace here.

> Source/bmalloc/bmalloc/IsoHeap.h:60
> -    
> +

Removed whitespace here.

Doesn’t seem like we should make both those changes.

> Source/bmalloc/bmalloc/IsoTLS.h:108
> -
> +    

Again adding whitespace.

> Source/bmalloc/bmalloc/IsoTLSInlines.h:99
> +    // since we don't want unpredictable behavior of offset or m_extent ever
got corrupted.

typo: "of" instead of "if"