[webkit-reviews] review granted: [Bug 179950] RenderBlockFlow::layoutRunsAndFloatsInRange is O(n^2) for runs of inlines without any text : [Attachment 327456] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 179950: RenderBlockFlow::layoutRunsAndFloatsInRange is O(n^2) for runs of
inlines without any text
https://bugs.webkit.org/show_bug.cgi?id=179950

Attachment 327456: patch

https://bugs.webkit.org/attachment.cgi?id=327456&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 327456
  --> https://bugs.webkit.org/attachment.cgi?id=327456
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327456&action=review

> Source/WebCore/platform/text/BidiResolver.h:248
> +    bool needsContinuePastEnd() { return
static_cast<DerivedClass&>(*this).needsContinuePastEndInternal(); }

make the function const.

> Source/WebCore/platform/text/BidiResolver.h:281
> +    bool needsContinuePastEndInternal() { return true; }

const

> Source/WebCore/platform/text/BidiResolver.h:297
> +    bool needsContinuePastEndInternal();

const

> Source/WebCore/rendering/InlineIterator.h:590
> +inline bool InlineBidiResolver::needsContinuePastEndInternal()

const