[webkit-reviews] review granted: [Bug 177338] Remove build-webkit's notion of feature flags having a default value : [Attachment 327435] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 177338: Remove build-webkit's notion of feature flags having a default
value
https://bugs.webkit.org/show_bug.cgi?id=177338

Attachment 327435: Patch

https://bugs.webkit.org/attachment.cgi?id=327435&action=review




--- Comment #37 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 327435
  --> https://bugs.webkit.org/attachment.cgi?id=327435
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327435&action=review

> Source/cmake/OptionsGTK.cmake:161
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_RTC PRIVATE
${ENABLE_EXPERIMENTAL_FEATURES})

I think this line should be removed.
We don't longer enable webrtc (not even on experimental builds) after we
dropped the openwebrtc backend.
The new backend based on libwebrtc is yet not ready to be enabled