[webkit-reviews] review granted: [Bug 179924] Some FELighting cleanup : [Attachment 327418] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 179924: Some FELighting cleanup
https://bugs.webkit.org/show_bug.cgi?id=179924

Attachment 327418: Patch

https://bugs.webkit.org/attachment.cgi?id=327418&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 327418
  --> https://bugs.webkit.org/attachment.cgi?id=327418
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327418&action=review

I continue to wish we had a vector type as IntSize is weird.  I can't remember
why we don't have one.	Is it because we don't want another type representing a
pair of ints?  Or is it naming? Or something else.

> Source/WebCore/platform/graphics/filters/FELighting.cpp:95
> +inline IntSize FELighting::LightingData::topLeftNormal(int offset) const

I wish we had a better type for this type of vector.