[webkit-reviews] review granted: [Bug 179849] downcast to WebKit::FullscreenClient can sometimes fail. : [Attachment 327273] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jeremy Jones <jeremyj-wk at apple.com>'s
request for review:
Bug 179849: downcast to WebKit::FullscreenClient can sometimes fail.
https://bugs.webkit.org/show_bug.cgi?id=179849

Attachment 327273: Patch

https://bugs.webkit.org/attachment.cgi?id=327273&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 327273
  --> https://bugs.webkit.org/attachment.cgi?id=327273
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327273&action=review

I worry that the issue is deeper than just a bd cast. If
_setFullscreenDelegate: does nothing because we are on a different fullscreen
client, then the old fullscreen client might be left with the delegate still
set. That could be a dangling pointer.

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:4778
>      return nullptr;

I think this should be return nil.