[webkit-reviews] review granted: [Bug 179888] [Cairo] drawNativeImage(), drawPattern() in CairoOperations should operate directly with cairo_surface_t objects : [Attachment 327365] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 21 01:26:09 PST 2017
Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 179888: [Cairo] drawNativeImage(), drawPattern() in CairoOperations should
operate directly with cairo_surface_t objects
https://bugs.webkit.org/show_bug.cgi?id=179888
Attachment 327365: Patch
https://bugs.webkit.org/attachment.cgi?id=327365&action=review
--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 327365
--> https://bugs.webkit.org/attachment.cgi?id=327365
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=327365&action=review
> Source/WebCore/platform/graphics/cairo/CairoOperations.h:96
> -void drawGlyphs(GraphicsContext&, const GraphicsContextState&, bool, const
FloatPoint&, cairo_scaled_font_t*, double, const Vector<cairo_glyph_t>&, float,
GraphicsContext&);
> +void drawGlyphs(PlatformContextCairo&, const GraphicsContextState&, const
FloatPoint&, cairo_scaled_font_t*, double, const Vector<cairo_glyph_t>&, float,
GraphicsContext&);
Is this related to this change? I'm surprised it builds.
More information about the webkit-reviews
mailing list