[webkit-reviews] review requested: [Bug 177932] [GTK] New API to add, retrieve and delete cookies via WebKitCookieManager : [Attachment 327360] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has asked  for review:
Bug 177932: [GTK] New API to add, retrieve and delete cookies via
WebKitCookieManager
https://bugs.webkit.org/show_bug.cgi?id=177932

Attachment 327360: Patch proposal

https://bugs.webkit.org/attachment.cgi?id=327360&action=review




--- Comment #25 from Mario Sanchez Prada <mario at webkit.org> ---
Created attachment 327360

  --> https://bugs.webkit.org/attachment.cgi?id=327360&action=review

Patch proposal

(In reply to Juan Pablo Ugarte from comment #24)
> (In reply to Mario Sanchez Prada from comment #23)
> [...] 
> > I think, though, that the API he really needed was add() and get(), as we
> > proposed delete() too just for the API to be complete IIRC, so we might not
> > get more light on that from his side (in which case we might consider
simply
> > not adding it, although the API would be a bit unbalanced in that case).
> 
> Right, my use case only require add() and get() but we tough it would be
> better to have delete() for API completeness.
> 
> I agree is better to maintain consistency with libsoup API and make delete()
> take a SoupCookie *, specially if its makes the implementation easier.

Thanks. So, considering that Michael said he _slightly_ preferred (a) if that
means less work for apps but that's unclear to be the case since you need the
name anyway, I think we might be all onboard then with (b), so here is a new
patch. Hopefully the last one!

Please review, thanks!