[webkit-reviews] review granted: [Bug 179867] Eliminate some cases of double hashing, other related refactoring : [Attachment 327331] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 179867: Eliminate some cases of double hashing, other related refactoring
https://bugs.webkit.org/show_bug.cgi?id=179867

Attachment 327331: Patch

https://bugs.webkit.org/attachment.cgi?id=327331&action=review




--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 327331
  --> https://bugs.webkit.org/attachment.cgi?id=327331
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327331&action=review

> Source/WebCore/html/FormController.cpp:325
> +	   String signature = formSignature(*form);

I would use auto here.

> Source/WebCore/html/FormController.h:37
> +using FormControlState = Vector<String>;

Nice.

> Source/WebCore/html/HTMLTextAreaElement.cpp:117
> +    return m_isDirty ? FormControlState { { value() } } : FormControlState {
};

In cases like these, I wonder if 

if (!m_dirty)
    return { };
return { { value() } };

is nicer due to not needing to restate FormControlState.  But looking at it, I
think the ternary is nicer.