[webkit-reviews] review requested: [Bug 173793] Move JSONValues to WTF and convert uses of InspectorValues.h to JSONValues.h : [Attachment 327345] Proposed Fix v2

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has asked	for review:
Bug 173793: Move JSONValues to WTF and convert uses of InspectorValues.h to
JSONValues.h
https://bugs.webkit.org/show_bug.cgi?id=173793

Attachment 327345: Proposed Fix v2

https://bugs.webkit.org/attachment.cgi?id=327345&action=review




--- Comment #36 from Brian Burg <bburg at apple.com> ---
Created attachment 327345

  --> https://bugs.webkit.org/attachment.cgi?id=327345&action=review

Proposed Fix v2

This approach seems workable, though the migration path towards reasonable
symbols is quite extended. I think it may make more sense in the refactoring
sense to pull the JSON RPC server parts into a new class, and only keep around
the old InspectorBackendDispatcher class for legacy linking purposes. Please
read the JSC changelog for full details of the workarounds needed to make this
work for iOS public SDK builds.