[webkit-reviews] review granted: [Bug 179497] AX: AOM: Implement number type properties : [Attachment 327320] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 18 22:03:23 PST 2017


chris fleizach <cfleizach at apple.com> has granted Nan Wang <n_wang at apple.com>'s
request for review:
Bug 179497: AX: AOM: Implement number type properties
https://bugs.webkit.org/show_bug.cgi?id=179497

Attachment 327320: patch

https://bugs.webkit.org/attachment.cgi?id=327320&action=review




--- Comment #9 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 327320
  --> https://bugs.webkit.org/attachment.cgi?id=327320
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327320&action=review

> Source/WebCore/accessibility/AccessibleNode.cpp:290
> +	   const String& value = 
element.attributeWithoutSynchronization(ariaAttributeMap().get(propertyName));

extra space after =

> Source/WebCore/accessibility/AccessibleNode.cpp:304
> +	   return
element.attributeWithoutSynchronization(ariaAttributeMap().get(propertyName)).t
oFloat();

toDouble() ?


More information about the webkit-reviews mailing list