[webkit-reviews] review granted: [Bug 179859] [WTF] Remove CPU(HPPA) in StackBounds by using runtime stack direction test : [Attachment 327310] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 18 06:05:31 PST 2017


JF Bastien <jfbastien at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 179859: [WTF] Remove CPU(HPPA) in StackBounds by using runtime stack
direction test
https://bugs.webkit.org/show_bug.cgi?id=179859

Attachment 327310: Patch

https://bugs.webkit.org/attachment.cgi?id=327310&action=review




--- Comment #5 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 327310
  --> https://bugs.webkit.org/attachment.cgi?id=327310
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327310&action=review

r=me with bugfix

> Source/WTF/wtf/StackBounds.cpp:72
> +	   result = testStackDirection(nullptr);

That won’t compile with nullptr :)


More information about the webkit-reviews mailing list