[webkit-reviews] review granted: [Bug 179833] FETurbulence: compute all 4 channels at once : [Attachment 327286] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 179833: FETurbulence: compute all 4 channels at once
https://bugs.webkit.org/show_bug.cgi?id=179833

Attachment 327286: Patch

https://bugs.webkit.org/attachment.cgi?id=327286&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 327286
  --> https://bugs.webkit.org/attachment.cgi?id=327286
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327286&action=review

> Source/WebCore/platform/graphics/ColorUtilities.h:42
> +    FloatComponents& operator +=(const FloatComponents& rhs)

We don't usually put a space after 'operator'.

> Source/WebCore/platform/graphics/ColorUtilities.h:51
> +    FloatComponents operator +(float rhs) const

We don't usually put a space after 'operator'.

> Source/WebCore/platform/graphics/ColorUtilities.h:61
> +    FloatComponents operator /(float denominator) const

We don't usually put a space after 'operator'.

> Source/WebCore/platform/graphics/ColorUtilities.h:71
> +    FloatComponents operator *(float factor) const

We don't usually put a space after 'operator'.