[webkit-reviews] review granted: [Bug 179848] Use a strongly typed identifier for SWServer::Connection : [Attachment 327266] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 17 16:35:36 PST 2017


Brady Eidson <beidson at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 179848: Use a strongly typed identifier for SWServer::Connection
https://bugs.webkit.org/show_bug.cgi?id=179848

Attachment 327266: Patch

https://bugs.webkit.org/attachment.cgi?id=327266&action=review




--- Comment #2 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 327266
  --> https://bugs.webkit.org/attachment.cgi?id=327266
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327266&action=review

r+ with a naming comment

> Source/WTF/wtf/ObjectIdentifier.h:65
> +    uint64_t toUnsignedInteger() const { return m_identifier; }

toUInt64()


More information about the webkit-reviews mailing list