[webkit-reviews] review requested: [Bug 179642] ServiceWorker Inspector: Frontend changes to support Network tab and sub resources : [Attachment 327258] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 17 15:49:37 PST 2017


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 179642: ServiceWorker Inspector: Frontend changes to support Network tab
and sub resources
https://bugs.webkit.org/show_bug.cgi?id=179642

Attachment 327258: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=327258&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Created attachment 327258

  --> https://bugs.webkit.org/attachment.cgi?id=327258&action=review

[PATCH] Proposed Fix

There are a few things I want to address in follow-ups:

1. Image resources added via CacheStorage.prototype.add / fetch() don't show up
properly
  - this is essentially pre-existing bad behavior for fetching any binary
content

2. Metrics data is not included
  - this requires enabling ResourceTiming in ServiceWorkers, which I'll be
looking into


More information about the webkit-reviews mailing list