[webkit-reviews] review denied: [Bug 179844] REGRESSION(r224390): Correct Ref -> RefPtr : [Attachment 327248] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 17 14:57:43 PST 2017
Chris Dumez <cdumez at apple.com> has denied Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 179844: REGRESSION(r224390): Correct Ref -> RefPtr
https://bugs.webkit.org/show_bug.cgi?id=179844
Attachment 327248: Patch
https://bugs.webkit.org/attachment.cgi?id=327248&action=review
--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 327248
--> https://bugs.webkit.org/attachment.cgi?id=327248
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=327248&action=review
> Source/WebCore/html/HTMLFrameOwnerElement.cpp:117
> + auto document = makeRef(*contentDocument);
Why do we even want a Refptr here? This seems to cause churn for no reason.
More information about the webkit-reviews
mailing list