[webkit-reviews] review granted: [Bug 179817] [WPE] Build C API tests : [Attachment 327165] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 179817: [WPE] Build C API tests
https://bugs.webkit.org/show_bug.cgi?id=179817

Attachment 327165: Patch

https://bugs.webkit.org/attachment.cgi?id=327165&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 327165
  --> https://bugs.webkit.org/attachment.cgi?id=327165
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327165&action=review

> Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:68
> +    if (m_window)
> +	   delete m_window;

delete is NULL-safe, so remove the if (m_window) check.

> Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:89
> +    // FIXME: implement this.

What happened to using notImplemented()? :D