[webkit-reviews] review requested: [Bug 179814] [Win] forwarding headers should not be copies : [Attachment 327160] Patch set #2 checks if the perl script to create forwarding headers returns an error; if so it causes the batch script to return an error and the build stops.

[bugzilla-daemon at webkit.org]

Mark Salisbury <mark.salisbury at hp.com> has asked  for review:
Bug 179814: [Win] forwarding headers should not be copies
https://bugs.webkit.org/show_bug.cgi?id=179814

Attachment 327160: Patch set #2 checks if the perl script to create forwarding
headers returns an error; if so it causes the batch script to return an error
and the build stops.

https://bugs.webkit.org/attachment.cgi?id=327160&action=review




--- Comment #3 from Mark Salisbury <mark.salisbury at hp.com> ---
Created attachment 327160

  --> https://bugs.webkit.org/attachment.cgi?id=327160&action=review

Patch set #2 checks if the perl script to create forwarding headers returns an
error; if so it causes the batch script to return an error and the build stops.

hmmm...  I realize my patch isn't formatted quite right.  Some time later I
suppose I'll have to figure out why prepare-ChangeLog is dying:

D:\git\webkit-upstream>perl Tools\Scripts\prepare-ChangeLog
--git-commit=HEAD~1...HEAD
  Running status to find changed, added, or removed files.
  Reviewing diff to determine which lines changed.
  Extracting affected function names from source files.
Use of uninitialized value $first_line in pattern match (m//) at
Tools\Scripts\prepare-ChangeLog line 765.
  Change author: Mark Salisbury <mark.salisbury at hp.com>.
  Editing the Source\JavaScriptCore\ChangeLog file.
-- Please remember to include a detailed description in your ChangeLog entry.
--
-- See <http://webkit.org/coding/contributing.html> for more info --

I found a bug in webkit-patch if SVN is not installed...  I'll have to submit a
fix for that.