[webkit-reviews] review granted: [Bug 179790] [WinCairo] Update WinCairoRequirements : [Attachment 327116] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 16 18:11:34 PST 2017


Alex Christensen <achristensen at apple.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 179790: [WinCairo] Update WinCairoRequirements
https://bugs.webkit.org/show_bug.cgi?id=179790

Attachment 327116: Patch

https://bugs.webkit.org/attachment.cgi?id=327116&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 327116
  --> https://bugs.webkit.org/attachment.cgi?id=327116
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327116&action=review

> Source/WebCore/PlatformWin.cmake:306
>	   DESTINATION
>	   ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/WebKit.resources/certificates

Can't you specify a destination filename instead of copying then renaming?


More information about the webkit-reviews mailing list