[webkit-reviews] review granted: [Bug 176577] SVG scrolling anchor should be reset if the fragmentIdentifier does not exist or is not provided : [Attachment 327134] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 176577: SVG scrolling anchor should be reset if the fragmentIdentifier does
not exist or is not provided
https://bugs.webkit.org/show_bug.cgi?id=176577

Attachment 327134: Patch

https://bugs.webkit.org/attachment.cgi?id=327134&action=review




--- Comment #21 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 327134
  --> https://bugs.webkit.org/attachment.cgi?id=327134
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327134&action=review

> Source/WebCore/page/FrameView.cpp:2211
> +	       document.updateStyleIfNeeded();

Please add a comment saying why this eager style update is necessary. Ideally,
you'd put it before the thing that needs it, not after something that may
change style.