[webkit-reviews] review granted: [Bug 179774] Make sure service workers get terminated between tests : [Attachment 327093] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 179774: Make sure service workers get terminated between tests
https://bugs.webkit.org/show_bug.cgi?id=179774

Attachment 327093: Patch

https://bugs.webkit.org/attachment.cgi?id=327093&action=review




--- Comment #2 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 327093
  --> https://bugs.webkit.org/attachment.cgi?id=327093
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327093&action=review

> Source/WebCore/workers/service/server/SWServerJobQueue.cpp:52
> +	   clearRegistration(*registration);

What is the intended side effect of clearRegistration?

Is this what is called when a WebPage actually clears its service worker?

If so, this patch would have the side effect of clearing *persistent*
registrations too, and we don't want to do this between tests.