[webkit-reviews] review granted: [Bug 179734] It should be easier to reify lazy property names : [Attachment 327075] patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted JF Bastien
<jfbastien at apple.com>'s request for review:
Bug 179734: It should be easier to reify lazy property names
https://bugs.webkit.org/show_bug.cgi?id=179734

Attachment 327075: patch

https://bugs.webkit.org/attachment.cgi?id=327075&action=review




--- Comment #10 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 327075
  --> https://bugs.webkit.org/attachment.cgi?id=327075
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327075&action=review

r=me.

> Source/JavaScriptCore/runtime/JSFunction.h:204
> +    enum class PropertyStatus {
> +	   Eager,
> +	   Lazy,
> +	   Reified,
> +    };
> +    static bool isLazy(PropertyStatus property) { return property ==
PropertyStatus::Lazy || property == PropertyStatus::Reified; }
> +    static bool isReified(PropertyStatus property) { return property ==
PropertyStatus::Reified; }
> +
> +    PropertyStatus reifyLazyPropertyIfNeeded(VM&, ExecState*, PropertyName);
> +    PropertyStatus reifyLazyPropertyForHostOrBuiltinIfNeeded(VM&,
ExecState*, PropertyName);
> +    PropertyStatus reifyLazyLengthIfNeeded(VM&, ExecState*, PropertyName);
> +    PropertyStatus reifyLazyNameIfNeeded(VM&, ExecState*, PropertyName);
> +    PropertyStatus reifyLazyBoundNameIfNeeded(VM&, ExecState*,
PropertyName);

It seems a little silly that we have all this in addition to the method table
functionality. Can you file a bug to clean this up later?