[webkit-reviews] review granted: [Bug 179692] Add feature define for alternative presentation button element : [Attachment 326924] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 179692: Add feature define for alternative presentation button element
https://bugs.webkit.org/show_bug.cgi?id=179692

Attachment 326924: Patch

https://bugs.webkit.org/attachment.cgi?id=326924&action=review




--- Comment #3 from Andy Estes <aestes at apple.com> ---
Comment on attachment 326924
  --> https://bugs.webkit.org/attachment.cgi?id=326924
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326924&action=review

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:252
> +ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT =
ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT;

I know that FeatureDefines are currently not sorted properly, but it would be
nice to not make it worse. Can you put this between
ENABLE_ACCELERATED_OVERFLOW_SCROLLING and ENABLE_APPLE_PAY?