[webkit-reviews] review canceled: [Bug 179538] webkitpy: Remove port dependencies in ServerProcess : [Attachment 326614] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has canceled Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 179538: webkitpy: Remove port dependencies in ServerProcess
https://bugs.webkit.org/show_bug.cgi?id=179538

Attachment 326614: Patch

https://bugs.webkit.org/attachment.cgi?id=326614&action=review




--- Comment #6 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 326614
  --> https://bugs.webkit.org/attachment.cgi?id=326614
Patch

I discussed this with Dan Bates on 11/14.

He is of the opinion that the ServerProcess should only be used for layout
tests.	As I've looked into how we use the server process, I think there is a
better way forward.

Throughout webkitpy, we have a number of places we could use an asynchronous
shell command.	For example, Simon mentioned to me a few days ago that when we
run sample after a layout test has hung, we block until the command has
returned.  There is no reason we need to block.

To solve this problem, I think we should split the server process into an
asynchronous subprocess call and the server process, which would use the
asynchronous subprocess call along with a few lifetime management tools and
callbacks.