[webkit-reviews] review granted: [Bug 179765] Provide a runtime option for disabling the optimization of recursive tail calls : [Attachment 327060] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 179765: Provide a runtime option for disabling the optimization of
recursive tail calls
https://bugs.webkit.org/show_bug.cgi?id=179765

Attachment 327060: Patch

https://bugs.webkit.org/attachment.cgi?id=327060&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 327060
  --> https://bugs.webkit.org/attachment.cgi?id=327060
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327060&action=review

r=me

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1318
> +    if (Options::optimizeRecursiveTailCalls()) {

I suggest making this:
    if (LIKELY(Options::optimizeRecursiveTailCalls())) {

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1425
> +    if (!Options::optimizeRecursiveTailCalls())

I suggest making this:
    if (UNLIKELY(!Options::optimizeRecursiveTailCalls()))