[webkit-reviews] review granted: [Bug 179551] Implement basics of "Terminate Service Worker" algorithm : [Attachment 327015] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 15 14:30:08 PST 2017


Chris Dumez <cdumez at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 179551: Implement basics of "Terminate Service Worker" algorithm
https://bugs.webkit.org/show_bug.cgi?id=179551

Attachment 327015: Patch

https://bugs.webkit.org/attachment.cgi?id=327015&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 327015
  --> https://bugs.webkit.org/attachment.cgi?id=327015
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327015&action=review

r=me with comment

> Source/WebCore/workers/WorkerThread.cpp:232
> +	   RunLoop::main().dispatch(WTFMove(m_stoppedCallback));

This is in Webcore, shouldn't it be a callOnMainThread() ?


More information about the webkit-reviews mailing list