[webkit-reviews] review granted: [Bug 179707] [Web Animations] Implement basic to-from animations : [Attachment 326993] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 179707: [Web Animations] Implement basic to-from animations
https://bugs.webkit.org/show_bug.cgi?id=179707

Attachment 326993: Patch

https://bugs.webkit.org/attachment.cgi?id=326993&action=review




--- Comment #14 from Dean Jackson <dino at apple.com> ---
Comment on attachment 326993
  --> https://bugs.webkit.org/attachment.cgi?id=326993
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326993&action=review

> Source/WebCore/animation/AnimationTimeline.h:73
> +    HashMap<RefPtr<Element>, Vector<RefPtr<WebAnimation>>>
elementToAnimationsMap() const { return m_elementToAnimationsMap; }

Should be returning &.

> Source/WebCore/animation/KeyframeEffect.cpp:46
> +    auto result = adoptRef(*new KeyframeEffect(target));
> +
> +    auto setKeyframesResult = result->setKeyframes(state,
WTFMove(keyframes));
> +    if (setKeyframesResult.hasException())
> +	   return setKeyframesResult.releaseException();
> +
> +    return WTFMove(result);

I'd rename result to keyframeEffect, but whatevs.

> Source/WebCore/style/StyleTreeResolver.cpp:283
> +	       std::unique_ptr<RenderStyle> animatedStyle =
RenderStyle::clonePtr(*newStyle);

Could use auto here.

>
LayoutTests/http/wpt/web-animations/timing-model/animations/set-the-animation-s
tart-time-expected.txt:3
> -FAIL Setting the start time of an animation without an active timeline
assert_equals: Start time remains null after setting current time expected
(object) null but got (number) -999.896
> -FAIL Setting an unresolved start time an animation without an active
timeline does not clear the current time assert_equals: Start time remains null
after setting current time expected (object) null but got (number) -999.896
> +FAIL Setting the start time of an animation without an active timeline
assert_equals: Start time remains null after setting current time expected
(object) null but got (number) -999.7033
> +FAIL Setting an unresolved start time an animation without an active
timeline does not clear the current time assert_equals: Start time remains null
after setting current time expected (object) null but got (number) -999.7033

Why has this changed?