[webkit-reviews] review granted: [Bug 179727] [WPE] Add initial support for WebDriver : [Attachment 326979] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 179727: [WPE] Add initial support for WebDriver
https://bugs.webkit.org/show_bug.cgi?id=179727

Attachment 326979: Patch

https://bugs.webkit.org/attachment.cgi?id=326979&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 326979
  --> https://bugs.webkit.org/attachment.cgi?id=326979
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326979&action=review

> Source/cmake/OptionsWPE.cmake:37
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBDRIVER PRIVATE ON)

I think Adrian wants this to be public, since he has support in his Buildroot
recipe for enabling and disabling it.

Adrian, do you want to keep that support? (I think the Buildroot recipe should
only touch public options.)