[webkit-reviews] review granted: [Bug 179701] Add a base class for HTMLCanvasElement and OffscreenCanvas : [Attachment 326938] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Dean Jackson <dino at apple.com>'s request
for review:
Bug 179701: Add a base class for HTMLCanvasElement and OffscreenCanvas
https://bugs.webkit.org/show_bug.cgi?id=179701

Attachment 326938: Patch

https://bugs.webkit.org/attachment.cgi?id=326938&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 326938
  --> https://bugs.webkit.org/attachment.cgi?id=326938
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326938&action=review

> Source/WebCore/html/CanvasBase.h:29
> +#include "IntSize.h"
> +#include "ScriptExecutionContext.h"

These can probably be forward declared.

> Source/WebCore/html/CanvasBase.h:40
> +public:
> +
> +    virtual ~CanvasBase() = default;

Extra newline.