[webkit-reviews] review granted: [Bug 179671] Stub implementations of OffscreenCanvas getContext and transferToImageBitmap : [Attachment 326887] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 179671: Stub implementations of OffscreenCanvas getContext and
transferToImageBitmap
https://bugs.webkit.org/show_bug.cgi?id=179671

Attachment 326887: Patch

https://bugs.webkit.org/attachment.cgi?id=326887&action=review




--- Comment #3 from Antoine Quint <graouts at apple.com> ---
Comment on attachment 326887
  --> https://bugs.webkit.org/attachment.cgi?id=326887
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326887&action=review

> Source/WebCore/html/OffscreenCanvas.cpp:71
> +    return { nullptr };

Shouldn't it be { }?

> Source/WebCore/html/OffscreenCanvas.h:71
> +    // FIXME: Should be optional<OffscreenRenderingContext> from above.

Is there a bug for this? Shouldn't we discard OffscreenRenderingContext until
it's ready to use?