[webkit-reviews] review denied: [Bug 179668] WebSWClientConnection should do IPC to StorageProcess if its WebSWOriginTable is not yet initialized : [Attachment 326877] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied youenn fablet <youennf at gmail.com>'s
request for review:
Bug 179668: WebSWClientConnection should do IPC to StorageProcess if its
WebSWOriginTable is not yet initialized
https://bugs.webkit.org/show_bug.cgi?id=179668

Attachment 326877: Patch

https://bugs.webkit.org/attachment.cgi?id=326877&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 326877
  --> https://bugs.webkit.org/attachment.cgi?id=326877
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326877&action=review

> Source/WebKit/WebProcess/Storage/WebSWOriginTable.h:43
> +    bool isInitialized() const { return
m_serviceWorkerOriginTable.sharedMemory(); }

The StorageProcess only sends a SharedMemoryHandle once the store actually
contains at least one item. A store can be initialized and have no shared
memory, in which case it merely means it is empty. Going to the StorageProcess
in such cases is wrong and unnecessarily inefficient.

> LayoutTests/ChangeLog:8
> +	   * http/tests/workers/service/basic-unregister.https-expected.txt:

Please explain the test changes.