[webkit-reviews] review granted: [Bug 179649] Send ServiceWorkerData structs to the WebProcesses instead of ServiceWorkerIdentifiers : [Attachment 326844] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 13 22:02:08 PST 2017


Brady Eidson <beidson at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 179649: Send ServiceWorkerData structs to the WebProcesses instead of
ServiceWorkerIdentifiers
https://bugs.webkit.org/show_bug.cgi?id=179649

Attachment 326844: Patch

https://bugs.webkit.org/attachment.cgi?id=326844&action=review




--- Comment #3 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 326844
  --> https://bugs.webkit.org/attachment.cgi?id=326844
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326844&action=review

> Source/WebCore/workers/service/ServiceWorkerData.cpp:40
> +    return {
> +	   identifier,
> +	   scriptURL.isolatedCopy(),
> +	   state,
> +	   type
> +    };

We don't normally multi-line something like this.


More information about the webkit-reviews mailing list