[webkit-reviews] review granted: [Bug 179654] Web Inspector: Cleanup navigation bar dividers and separators : [Attachment 326847] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <webkit at devinrousso.com> has granted Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 179654: Web Inspector: Cleanup navigation bar dividers and separators
https://bugs.webkit.org/show_bug.cgi?id=179654

Attachment 326847: Patch

https://bugs.webkit.org/attachment.cgi?id=326847&action=review




--- Comment #4 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 326847
  --> https://bugs.webkit.org/attachment.cgi?id=326847
Patch

r=me.

I think that changing the chevron is awesome, but I think we might want to
adjust the margin to make it more even on both sides.  With this patch (and
before it too actually), it looked like the divider was shifted more towards
the left, and there was an uneven amount of space when compared to the right
side.  I think we should adjust this.

HierarchicalPathComponent.css
    .hierarchical-path-component > .separator {
	--path-component-separator-margin-start: 4px; // or use
`-webkit-margin-start: 4px;`
    }

Also, it's slightly weird to have a separator before/after the sidebar icons,
but not elsewhere.  I'm not sure if Xcode has anything similar :(