[webkit-reviews] review granted: [Bug 179640] ServiceWorker Inspector: Add a ServiceWorker domain to get information about an inspected ServiceWorker : [Attachment 326816] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <webkit at devinrousso.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 179640: ServiceWorker Inspector: Add a ServiceWorker domain to get
information about an inspected ServiceWorker
https://bugs.webkit.org/show_bug.cgi?id=179640

Attachment 326816: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=326816&action=review




--- Comment #3 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 326816
  --> https://bugs.webkit.org/attachment.cgi?id=326816
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=326816&action=review

r=me.  Some tests would be nice :D

> Source/JavaScriptCore/inspector/protocol/ServiceWorker.json:19
> +	       "name": "getInitializationInfo",

Do we have the ability to do inspector tests for ServiceWorkers?  I'd assume so
considering we have instrumentation for regular Workers.  Please write a test
for this, or include a FIXME/comment explaining why you can't. :)

> Source/WebCore/inspector/agents/worker/ServiceWorkerAgent.h:49
> +    // ServiceWorkerBackendDispatcher

What is our usual naming convention for this?  I've seen "Called from frontend"
and "*BackendDispatcherHandler".  I think this should be
"ServiceWorkerBackendDispatcherHandler".